[MPlayer-dev-eng] [PATCH] don't quit playing audio if video stream ends

Uoti Urpala uoti.urpala at pp1.inet.fi
Sat Aug 5 15:02:09 CEST 2006


On Sat, 2006-08-05 at 12:47 +0200, Nico Sabbi wrote:
> Currently, when the video stream ends mplayer quits
> even if there is still some remaining audio data to play.
> The patch attached fixes this bug permitting mplayer to keep on
> playing audio until the end.

IMO it'd be better if video wasn't closed when the video part of stream
ends, so that you could still seek back and see video. I think this
patch would cause ugly failures when seeking back to a part which still
has video ("too many video packets in buffer" error messages I'd guess,
haven't tested).

Just not updating the video if it's currently past the end should be
easy enough, though doing it simply would mean that the OSD would not be
updated either during the audio-only part. This is also related to a
feature I've sometimes wanted myself, ability to NOT quit when hitting
end of file (either playing or accidentally seeking past end of it) so
you could just seek back. Main open question is whether there's any
demuxer which would break if you fall off the end of the file and then
seek back.

There could also be demuxing-related problems with files where one
stream ends. MPlayer tries to keep both audio and video buffered, and I
think it'd currently end up trying to buffer the whole remaining part of
the other stream while searching for more frames in the ending stream.

> In incoming there's a sample called 
> streamdump-of-dvd-title-requires-novideo.vob
> that shows the difference (it has to be played with -demuxer lavf).

IIRC I didn't use -demuxer lavf when it was first discussed on IRC and I
verified why it behaves like it does, but I could remember wrong...





More information about the MPlayer-dev-eng mailing list