[MPlayer-dev-eng] [PATCH] mention libdvdnav in 'configure --help' and switch autodetection on

[The Wanderer]

Diego Biurrun wrote:

> On Fri, Aug 04, 2006 at 08:28:41AM -0400, The Wanderer wrote:
> 
>> Apparently, even though configure recognizes the '--enable-dvdnav',
>> '--with-dvdnavdir' and '--with-dvdnav-config' options, they are
>> not listed in 'configure --help' - and, possibly as a result,
>> dvdnav support still defaults to "no" with autodetection run if it
>> is set to "yes". The attached patch corrects both points. If there
>> was some reason why dvdnav was disabled by default, it should still
>> be listed as such in the help output; in any case, it appears to
>> compile just fine for me, though I'm not presently in a position to
>> test the resulting binary.
> 
> I commented out all the dvdnav stuff ages ago because it was not
> working.  Nico reenabled it in preparation for the dvdnav patch from
> Attila Otvos.  I'm not quite sure in what state it is right now, so
> I'm somewhat hesitant to add them back.

Acknowledged. Does this, in fact, mean that the options should not be
documented in --help? Or should they be there, but default to 'disabled'?

>> (Having noticed that one set of options was missing from the help
>> output, I went over the script as exhaustively as I could quickly
>> manage to look for others; the only one I found is '--enable-mtrr'.
>> It was in my initial patch, but I've removed it as unrelated; it
>> should be easy enough to add in any case. From what I've been able
>> to tell, its functionality - unlike that of dvdnav - seems
>> unimpaired.)
> 
> This one should be added.  Send a patch/commit.

Will do.

>> I've also noticed that:
>> 
>> A) The output of 'configure --help' is somewhat unorganized, from
>> the perspective of comparing it point by point against variables as
>> they are set to their defaults. Rearranging either the help output
>> or the variable 'declarations' would make the help output easier to
>> maintain; this is something I could easily do, and I have no strong
>> preference as to which. Off the top of my head, I see no particular
>> reason why most of the variables couldn't be switched around, but
>> it's entirely possible there's something I'm missing. There is
>> somewhat more importance to keeping the output text in a particular
>> order, to be adequately intuitive to the user, but I'm not certain
>> it couldn't do with some rearranging as well; if there are
>> particular points of the current arrangement which are intentional
>> and should be preserved (beyond such obvious ones as "list output
>> drivers together" and the like), please let me know.
> 
> There is not much intentional about it.  The help output should be in
> a logical order.

What would qualify as logical, then, aside from the kneejerk
"alphabetical order within categories"? I could certainly take a stab at
it, but I've long since discovered that my ideas of what makes sense
don't necessarily agree with those of other people.

>> B) There are a number of inconsistencies in the help output - most
>> obviously, differences in capitalization of option descriptions
>> (compare the '--enable-live' and '--enable-menu' options for an
>> example). There are also some odd indentation issues, and a few
>> possible 'grammar' errors (mostly miscapitalization of names).
>> Fixing this would be an entirely cosmetic change, affecting most of
>> that section of the script, but I think it might be worthwhile in
>> principle.
> 
> Go right ahead.

Since this can be done independently of any of the changes above, and
would conflict with any of them, I think I'll do either this or the much
simpler 'mtrr' one first. Expect a SVN-account mail from me in the next
day or so, once I finally settle on a (sufficiently non-guessable)
password I'm happy with.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.