[MPlayer-dev-eng] [PATCH] mention libdvdnav in 'configure --help' and switch autodetection on

[The Wanderer]

Apparently, even though configure recognizes the '--enable-dvdnav',
'--with-dvdnavdir' and '--with-dvdnav-config' options, they are not
listed in 'configure --help' - and, possibly as a result, dvdnav support
still defaults to "no" with autodetection run if it is set to "yes". The
attached patch corrects both points. If there was some reason why dvdnav
was disabled by default, it should still be listed as such in the help
output; in any case, it appears to compile just fine for me, though I'm
not presently in a position to test the resulting binary.

(Having noticed that one set of options was missing from the help
output, I went over the script as exhaustively as I could quickly manage
to look for others; the only one I found is '--enable-mtrr'. It was in
my initial patch, but I've removed it as unrelated; it should be easy
enough to add in any case. From what I've been able to tell, its
functionality - unlike that of dvdnav - seems unimpaired.)

I've also noticed that:

A) The output of 'configure --help' is somewhat unorganized, from the
perspective of comparing it point by point against variables as they are
set to their defaults. Rearranging either the help output or the
variable 'declarations' would make the help output easier to maintain;
this is something I could easily do, and I have no strong preference as
to which. Off the top of my head, I see no particular reason why most of
the variables couldn't be switched around, but it's entirely possible
there's something I'm missing. There is somewhat more importance to
keeping the output text in a particular order, to be adequately
intuitive to the user, but I'm not certain it couldn't do with some
rearranging as well; if there are particular points of the current
arrangement which are intentional and should be preserved (beyond such
obvious ones as "list output drivers together" and the like), please let
me know.

B) There are a number of inconsistencies in the help output - most
obviously, differences in capitalization of option descriptions (compare
the '--enable-live' and '--enable-menu' options for an example). There
are also some odd indentation issues, and a few possible 'grammar'
errors (mostly miscapitalization of names). Fixing this would be an
entirely cosmetic change, affecting most of that section of the script,
but I think it might be worthwhile in principle.

Thoughts, if any?

(...and now that I've put my hat back in the ring, however minorly, I
suppose I'd better stop vacillating about password choices and get back
in there...)

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dvdnav-configure-help.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060804/e2cbdc56/attachment.txt>