[MPlayer-dev-eng] [PATCH] fix compilation when not using libvorbis

[Diego Biurrun]

On Fri, Aug 04, 2006 at 12:36:02AM +0200, Nico Sabbi wrote:
> Diego Biurrun wrote:
> 
> >On Thu, Aug 03, 2006 at 08:56:14PM +0200, Emanuele Giaquinta wrote:
> >
> >>demux_mov.c uses a "store_ughvlc" function defined in demux_ogg.c,
> >>causing a linking failure when the latter is not compiled in
> >>(conditional to libvorbis); attached patch adds the function to
> >>demux_mov.c and changes its linkage to internal in both files.
> >
> >Your patch duplicates the store_ughvlc function.  This is not good.
> >
> >I think Nico is up to something with regard to this..
> 
> my proposal is to add an mp_common.h somewhere (either in main/ or
> in libmpdemux/) and begin to put in there all the functions we usually
> need often.
> Over time a lot of functions were stored in the most desparate and
> inappropriate places (store_ughvlc(), realloc_struct() that is in 
> demuxer.h, and
> many more); it's time to finally find a home to those poor homeless

.. and if we put it in demuxer.h, if only for the moment? ..

Diego