[MPlayer-dev-eng] Re: [PATCH] dis-/enable playlist advancement

[Alban Bedel]

On Thu, 27 Apr 2006 13:37:40 +0200 (CEST)
Mark Pustjens <pustjens at dds.nl> wrote:

> Hello,
> 
> This patch adds commandline options to dis- or enable playlist 
> advancement. It also add a new command which can be bound to a key.
>
> You might want to be able to disable playlist advancement if you are 
> particulairy fond of a song. It is also usefull if mplayer is used in a 
> kiosk type application.
> 
> I have modified the manpage to include the commandline options. Please let 
> me know if there is any other documentation i should update.

What about just changing the loop setting instead ? It would be much simpler,
but that would requiere the media to be seekable. Perhaps both make sense.

Otherwise to the patch:

> +    case MP_CMD_PLAYLIST_ADVANCE: {
> +    	set_playlist_advance(playtree_iter, cmd->args[0].v.i);
> +    } break;

This should be a property instead to allow UIs to query the current state.

Regarding all the changes to the playtree code, i dunno if it's the right
approch. I don't really like the fact that the next command will stop
working. It should probably be better and simpler to handle that with a normal
option in mplayer.c. When enabled 0 would be passed to play_tree_iter_step
instead of -1/1. play_tree_iter_step would then just need a minor correction
to handle the case where d=0 in shuffle mode.

	Albeu