[MPlayer-dev-eng] [PATCH] UTF-8 osd messages

[Rich Felker]

On Fri, Apr 28, 2006 at 12:56:49AM +0200, Adam Tla?ka wrote:
> On Tue, Apr 25, 2006 at 02:56:59PM +0200, Reimar D???ffinger wrote:
> > Hi,
> > On Tue, Apr 25, 2006 at 09:54:02AM +0300, Ivan Kalvachev wrote:
> > > 2006/4/23, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > > > Also, the utf8_get_char function is a bit overkill for this, since it will
> > > > always encouter valid UTF-8 in this case, but I made it more flexible in
> > > > the hope in will be used in other place as well in the future.
> > > 
> > > I think this is going to be the second utf-8 parser in that file, as
> > > subs are (usually) already utf-8.
> > > Take a look of vo_update_text_sub::382
> > 
> > I know, but that code could in case of invalid encoding skip the terminating
> > NULL and cause a segfault. Thus it is unsuitable for most cases, and this is
> > actually one of the utf8-parsers I'd like to replace.
> > 
> What about storing strings internally in UCS-2?

ABSOLUTELY NOT!
UCS-2 is an abomination and should never be used for anything. Maybe
you meant UCS-4?
Still I'm against it. It should be possible to process strings as
strings EVERYWHERE up until the point where the actual characters are
printed. This is not possible with any encoding but UTF-8.

Rich