[MPlayer-dev-eng] Re: [PATCH] Allow aspect change in TS and DVB

[Nico Sabbi]

Ivan Kalvachev wrote:

>>My bad.
>>OK to commit.
>>    
>>
>
>by bad.
>Please before commit, check if mpeg1 and mpeg2 have different aspect
>codes. I can't do it atm.
>  
>

they are different (and mplayer is buggy):
IIUC mpeg1 defines A/R codes as pixel_aspect_ratio while mpeg2 defines 
display_aspect_ratio,
so in mpeg1 PAR = width / (DAR * height), correct?

The code in video.c seems to correctly handle mpeg2's dar (always) and 
mpeg1's par only at prefixed
resolution (now I remember that vlc sometimes shows a different A/R than 
expected when
playing mpeg1 video, maybe rightfully so).

If what I wrote is correct (someone confirm or deny, please) when 
playing mpeg1
sh_video->aspect (DAR) should be set to width / (PAR_float_code * height).

Michael and Ivan, please comment.

Updated  patch attached.

    Nico




-------------- next part --------------
A non-text attachment was scrubbed...
Name: aspect3.diff
Type: text/x-patch
Size: 4448 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060427/9d80e15f/attachment.bin>