[MPlayer-dev-eng] [PATCH] Add support for GNOME screensaver

[Reimar Döffinger]

Hi,
On Thu, Apr 27, 2006 at 07:20:26PM +0200, Piotr Kaczuba wrote:
> extension. But then again, why does mplayer has Xscreensaver and KDE screensaver
> support?

KDE screensaver? If there is already a special case for that, that would
of course make my objection moot.

> Gnome_screensaver.c consists of two functions, which both basically call
> another three functions. How is this too much code? How would you reduce
> it by 50%?

Well, I find it too much for something which I currently (without any
fact-checking) I see as a problem the gnome people created.
Also, I find it highly laughable that something as simple as preventing
the screensaver is more than 4 line max. But that's the same with
xscreensaver I must admit.
I guess such vague statements are annoying, I just wanted to express
something like "my gut smells crap", I won't mind anyone applying it
anyway though (after reviewing it), after all I'm in a complete lack of
facts.

Greetings,
Reimar Döffinger