[MPlayer-dev-eng] [PATCH] Add support for GNOME screensaver

[Piotr Kaczuba]

On Thu, Apr 27, 2006 at 12:36:13AM +0200, Diego Biurrun wrote:
[...]
> >  libvo/libvo.a:
> > -	$(MAKE) -C libvo
> > +	$(MAKE) -C libvo all
> 
> Why?
Because after applying my patch the libvo.a rule isn't the first one in
the Makefile anymore.

> 
> > --- configure	26 Apr 2006 01:59:05 -0000	1.1179
> > +++ configure	26 Apr 2006 18:11:41 -0000
> > @@ -6815,6 +6819,22 @@
> >  fi
> >  echores "$_gethostbyname2"
> >  
> > +echocheck "D-BUS GLib interface"
> > +if test "$_dbus_glib" != no && pkg-config --exists dbus-glib-1; then
> 
> The check should only run when _dbus_glib is set to auto.  The value yes
> is reserved to force the setting.
But what about the libs and includes? If we skip autodetection of the
paths to the libs and includes when the user sets _dbus_glib to yes, the
whole thing won't compile.

> > @@ -8116,6 +8138,14 @@
> >  OPTIONAL_OBJS = $_voobj
> >  EOF
> >  
> > +if test "$_x11" = yes -a "$_dbus_glib" = yes; then
> > +  cat >> libvo/config.mak << EOF
> > +
> > +gnome_screensaver.o: gnome_screensaver.c
> > +	\$(CC) -c \$(CFLAGS) \$(DBUS_GLIB_INC) -o \$@ $<
> > +EOF
> 
> I don't like this.  These rules belong in the Makefile, not somewhere
> else.
I can do that. That would also eliminate the "make all" patch above.

Piotr