[MPlayer-dev-eng] LDFLAGS and CPPFLAGS -> ended up in cvs admin -o

[Diego Biurrun]

On Thu, Apr 20, 2006 at 03:19:58PM +0200, Diego Biurrun wrote:
> On Thu, Apr 20, 2006 at 12:29:27PM +0200, Reimar Döffinger wrote:
> > On Thu, Apr 20, 2006 at 11:29:01AM +0200, =?ISO-8859-1?Q? G=E1bor_B=E9rczi_=28Gabucino=29 ?= wrote:
> > > +_ld_extra="$_ld_extra $LDFLAGS"
> > > +_inc_extra="$_inc_extra $CPPFLAGS"
> > 
> > I'd prefer the LDFLAGS/CPPCFLAGS/CFLAGS handling to be a bit more
> > consistent.
> > What about the attached patch?
> > I moved the CFLAGS stuff up, since CFLAGS are used in compile_check, I
> > think it really is better to set them before using that function.
> 
> I don't like moving that stuff around.  Options should only be checked
> once.  This has been annoying me forever, it also causes subtle bugs.
> I'm looking into it right now.

Reimar, commit anytime.  Removing the double option check kludge from
configure is going to take me some time still and I don't want to hold
this up.  Your patch doesn't really make the current situation any
worse.

Diego