[MPlayer-dev-eng] [PATCH] UTF-8 osd messages

Reimar =?UTF8?Q?D=F6ffinger?= Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Apr 25 14:56:59 CEST 2006


Hi,
On Tue, Apr 25, 2006 at 09:54:02AM +0300, Ivan Kalvachev wrote:
> 2006/4/23, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Also, the utf8_get_char function is a bit overkill for this, since it will
> > always encouter valid UTF-8 in this case, but I made it more flexible in
> > the hope in will be used in other place as well in the future.
> 
> I think this is going to be the second utf-8 parser in that file, as
> subs are (usually) already utf-8.
> Take a look of vo_update_text_sub::382

I know, but that code could in case of invalid encoding skip the terminating
NULL and cause a segfault. Thus it is unsuitable for most cases, and this is
actually one of the utf8-parsers I'd like to replace.

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list