[MPlayer-dev-eng] Re: [PATCH] Various improvement in TOOLS/cpuinfo.c

[Ivan Kalvachev]

2006/4/25, Zuxy Meng <zuxy.meng at gmail.com>:
> Hi,
>
> 2006/4/25, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org>:
> > On Tuesday, 25 April 2006 at 10:44, Zuxy Meng wrote:
> > [...]
> > > @@ -147,16 +158,16 @@
> > >        { 15, "cmov",  "Conditional Move/Compare Instruction" },
> > >        { 16, "pat",   "Page Attribute Table" },
> > >        { 17, "pse36", "Page Size Extension 36-bit" },
> > > -      { 18, "psn",   "Processor Serial Number" },
> > > +      { 18, "pn",   "Processor Serial Number" },
> >                       ^^^
> > Nit: misalignment. ;)
> >
> > >        { 19, "cflsh", "CFLUSH instruction" },
> > > -      { 21, "ds",    "Debug Store" },
> > > +      { 21, "dts",    "Debug Store" },
> >
> > Same here.
> >
> > >        { 22, "acpi",  "Thermal Monitor and Clock Ctrl" },
> > >        { 23, "mmx",   "MMX Technology" },
> > >        { 24, "fxsr",  "FXSAVE/FXRSTOR" },
> > >        { 25, "sse",   "SSE Extensions" },
> > >        { 26, "sse2",  "SSE2 Extensions" },
> > >        { 27, "ss",    "Self Snoop" },
> > > -      { 28, "htt",   "Multi-threading" },
> > > +      { 28, "ht",   "Multi-threading" },
> >
> > And here. Don't be afraid to add/remove a single space if the
> > change warrants it. :)
>
> Thanks:-) But, er, will it better to remove those stuff all together?
> MPlayer doesn't need a human readable description actually.

Better leave it. We are humans. I could not get from top of my head
what "pn" is.