[MPlayer-dev-eng] [PATCH] more swscale altivec fixes

[Michael Niedermayer]

Hi

On Mon, Apr 24, 2006 at 10:00:29PM -0400, Alan Curry wrote:
> Michael Niedermayer writes the following:
> >> 
> >> At least 3 more. There are 2 cases of assuming stride==width and 1 case of
> >> expecting the Y plane to be aligned at 16 bytes. They're independent bugs,
> >> but they all appear in the DEFCSP420_CVT macro which defines the functions
> >> altivec_yuv2_{argb,bgra,rgb24,...}.
> >
> >do we have a swscale-altivec maintainer? if no, then apply it, but with
> >special case(s) for the correctly aligned case so that the code isnt slowed
> >down
> 
> Special case as in a whole new set of scaler functions? Or adding an extra
> copy of the main loop with a single test being done every time the function
> is called?
> 
> The current version is neither fully optimized for aligned input nor fully
> correct for unaligned input, but halfway in between. Only the Y plane is
> assumed to be aligned; the U and V planes are loaded and shifted. There are 3
> independent assumptions that could be made there, so I could make 8 versions
> of the same loop. I assume nobody would want to see that.

ok, then your patch is fine
and as you are the sws-altivec maintainer, no need to send patches for
sws-altivec stuff anyway ...

[...]

-- 
Michael

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is