[MPlayer-dev-eng] [PATCH] MSGT_IDENTIFY (was: option to skip slow -identify output)

[Reynaldo H. Verdejo Pinochet]

On Mon, Apr 24, 2006 at 01:43:50AM -0400, Reynaldo H. Verdejo Pinochet wrote:
> On Mon, Apr 24, 2006 at 07:54:12AM +0300, Oded Shimon wrote:
> > On Sat, Apr 22, 2006 at 09:46:03AM -0400, kiriuja wrote:
> > > On Saturday 22 April 2006 09:16 Oded Shimon wrote:
> > > > On Thu, Apr 20, 2006 at 06:13:21PM -0400, kiriuja wrote:
> > > > > +    mp_msg_levels[MSGT_IDENTIFY] = -1; // no -identify output by default
> > > > 
> > > > I dislike this hack.
> > > > 
> > > > IMO you should make all identify MSGL_V, and the very bad ones, MSGL_DBG1 
> > > > (or 2 or whatever it was).
> > > 
> > > Currently there is no identify output unless you give -identify, regardless
> > > of the global msglevel. There is no reason to change that. So -1 is the
> > > only correct value for the default MSGT_IDENTIFY level.
> > 
> > Right, didn't realize that, ok.
> > 
> > > > Also, the man page should note that identify output is available by 
> > > > -msgl identify=..
> > > 
> > > The patch already includes a mention of that in mplayer.1.
> > 
> > Sorry, I meant it should mention that MORE output is available by -msgl 
> > identify=5 . It doesn't. Other than that, patch OK.
> > 
> > - ods15
> 
> I was going to commit this with an small change on mplayer.1:
> 
> --------------------------8<------------------
> Show file parameters in an easily parseable format.
> Also prints more detailed information about subtitle and audio
> track languages and IDs. If you want even more information
> use -msglevel identify=5.
> ------------------------>8---------------------
> 
> but wile testing I noticed there isnt such a difference, with
> -msglevel identify=5 i get basically the same output, maybe i got
> things wrong somewhere along the line?
> 
> Waiting
> 
>    Reynaldo

Commited.

Ok, i didnt waited too much, just hope the man page entry is right
if it isnt, let me know and I will fix it in no time.

Best regards

	Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060424/c2a40793/attachment.pgp>