[MPlayer-dev-eng] [PATCH] remove default.sub fallback

Diego Biurrun diego at biurrun.de
Mon Apr 24 01:22:02 CEST 2006


On Thu, Apr 20, 2006 at 11:25:18AM +0200, Reimar Döffinger wrote:
> On Thu, Apr 20, 2006 at 01:34:02AM +0200, Diego Biurrun wrote:
> > .. something like the patch below?
> 
> Yes, if nobody objects to the tiny bit of cosmetics.
> 
> > +    char *psub = get_path( "sub/" );
> > +    tmp = sub_filenames((psub ? psub : ""), filename);
> > +    free(psub);
> > +    subdata=sub_read_file(tmp[0], sh_video->fps);
> >      while (tmp && tmp[i])
> 
> For consistency, maybe change "while (tmp && tmp[i])" to
> "while (tmp[i])".
> Not important though (and a bit of cosmetics as well *g*

Applied together with that "cosmetic" change and a man page update.

Diego




More information about the MPlayer-dev-eng mailing list