[MPlayer-dev-eng] Re: [PATCH] GUI: fix audio/video id in gtk/menu.c

[Guillaume POIRIER]

Hi,

Stanislav Maslovski wrote:
> On Tue, Apr 11, 2006 at 11:57:10AM +0200, Nico Sabbi wrote:
> 
> [...]
> 
>>>> Isn't precisely -aid a counter example? On DVDs, "aid" starts at 128,
>>>> and on some dvb streams I've had on hand, it started at 130...
>>>>    
>>> Well, as i said i have checked only mkv and ogg demuxers ;) So, there is no
>>> standard for -aids and similar in mplayer?
>>>
>>> The GUI code treats DVD case in a different manner: the part of the code 
>>> the
>>> patch affects is simply skipped for a DVD (see line 23710 of gtk/menu.c).
>>>
>>> Where a dvb stream gets demuxed? I can add a special case for it.
>>>  
>> demux_ts.c. No special cases, please: they are evil
> 
> Okay, in the third patch I tried to be as little specific as possible.
> 
> The menu implementation that is currently in CVS (i.e. the old one, not mine)
> works correctly only for demuxers that have demux_aid_vid_mismatch set to 0.
> I check this in the patch now and keep the old functionality for this case.
> 
> The demuxers that have demux_aid_vid_mismatch set to 1 are currently only
> OGG, MATROSKA and TS. From demux_ts.c I see that it does not
> enumerate audio and video streams on opening (contrary to OGG and MATROSKA
> demuxers that do), hence for TS there is no sense in swithing the streams
> dynamically from the gui menu.
> 
> The OGG and MATROSKA demuxers are handled in a new manner, respectively to
> how they enumerate the streams.
> 
> The patch with removed cosmetics (i.e. with bad identation) is attached.
> Tell me when you need the patch that keeps good identation.
> 
> Please check it against MATROSKA movies, I do not have MSV movies that have
> several audio/video streams. It works for OGGs I have.

I tested with an mkv file, and I don't see anything that allows to 
switch audio channel on the menu that appears if I do a "right click".

Is that intended? I don't have any ogm file with two audio channels...

Guillaume