[MPlayer-dev-eng] [BUG] [PATCH] encoding with lavc and b-frames is partially broken

[Michael Niedermayer]

Hi

On Sun, Apr 23, 2006 at 10:57:38AM +0200, Nico Sabbi wrote:
> Nico Sabbi wrote:
> 
> >Hi,
> >since rvision 1.137
> >http://www1.mplayerhq.hu/cgi-bin/cvsweb.cgi/main/libmpcodecs/ve_lavc.c.diff?r1=1.136&r2=1.137 
> >
> >
> >for as many as INITIAL vmax_b_frames
> >{
> >   (out_size = avcodec_encode_video(lavc_venc_context, mux_v->buffer, 
> >mux_v->buffer_size, pic)) == -1
> >   [mpeg2video @ 0xb7e0d548]Error, Invalid timestamp=0, last=0
> >   muxer_write_chunk(mux_v, -1);
> >}
> >
> >consequently the reported bitrate (and avi header) tends to MAXINT
> >
> >The attached patch fixes it;  it's just a workaround, but maybe  it's 

wouldnt it then be appropriate to add a comment like
// this is a lame workaround to avoid vmax_b_frames zero PTS at the start
// the correct fix is to fix the code which sets the pts of several frames
// to equal values


> >acceptable considering that atm
> >no filter passes through the pts

many filters should pass pts through, but not all do yet, its the filter
authors job to fix it, but they dont care it seems ...

[...]

-- 
Michael

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is