[MPlayer-dev-eng] [PATCH] MSGT_IDENTIFY (was: option to skip slow -identify output)

[Oded Shimon]

On Thu, Apr 20, 2006 at 06:13:21PM -0400, kiriuja wrote:
> On Wednesday 19 April 2006 20:44 Alban Bedel wrote:
> > Personaly i would prefer to see the whole identify stuff move to mp_msg.
> > It shouldn't be too hard to have a single small hack so that -verbose and
> > -v doesn't change the level of MSGT_IDENTIFY. Then (in the long run) we
> > could get rid of all those if(indentify) that creep all over the place.
> > It would also make it trivial to have several level of identify.
> 
> Patch attached. Please check and apply before pre8 is out.

> +    mp_msg_levels[MSGT_IDENTIFY] = -1; // no -identify output by default

I dislike this hack.

IMO you should make all identify MSGL_V, and the very bad ones, MSGL_DBG1 
(or 2 or whatever it was).
Also, the man page should note that identify output is available by 
-msgl identify=..

- ods15