[MPlayer-dev-eng] [PATCH] SSA/ASS subtitles support

[Evgeniy Stepanov]

On Friday 21 April 2006 06:44, Uoti Urpala wrote:
> +demux_mkv_read_attachments (demuxer_t *demuxer)
>
> The memory allocated in this function is never freed. 

Attachments are kept in mkv_demuxer_t in the same way as chapters and indices, 
just for uniformity. This could be used in the future to write fonts to disk 
only when they are needed, or even to open them directly from memory.

If you think this takes too much memory, I can comment it out for now.

> Embedded fonts are 
> saved under the user's .mplayer directory, I think there should be at
> least an option to turn off such creation of new files. 

What should be the default value of such option ? Maybe simply not save the 
fonts when ~/.mplayer/fonts does not exist ?

> Because the 
> created files use names from the video file without any security checks,
> they can contain things like '../../' and thus new files can be created
> anywhere on the filesystem. There seems to be some kind of check against
> overwriting files, I don't see the point of that - it's obviously
> insufficient as a security check, and if there are different font files
> with the same name wouldn't you usually want to use the one from the
> video that was last opened?

Agreed.