[MPlayer-dev-eng] FFmpeg include header

[Ivan Kalvachev]

2006/4/20, Michael Niedermayer <michaelni at gmx.at>:
> Hi
>
> On Thu, Apr 20, 2006 at 11:16:47AM +0300, Ivan Kalvachev wrote:
> > 2006/4/20, Michael Niedermayer <michaelni at gmx.at>:
> > > Hi
> > >
> > > On Wed, Apr 19, 2006 at 11:52:53PM +0300, Ivan Kalvachev wrote:
> > > > Here is an early patch, it uses trick similar to what FreeType does to
> > > > declare include header paths.
> > > > You may have noticed that there are quite many places where #ifdef are
> > > > used to include ffmpeg headers from default system location or from
> > > > internal mplayer one.
> > > > This code duplication could be removed if we #define the path string
> > > > and include the define.
> > > >
> > > > The patch I created remove about 27 lines total, please take a look
> > > > and test it. At least I was able to compile mplayer with this patch
> > > > applied.
> > > >
> > > > I would like to hear your recommendations:
> > >
> > > what about using gcc ... -I<path to the headers> ?
> >
> > I may write a new patch,  after you explain me why ffmpeg headers are
> > put in separate "..include/ffmpeg/" directory.
>
> ahh thats easy to awnser, i have not the faintest clue why :)

Well unfortunately the reason not to use -I is the same as the reason
to put all headers in ffmpeg/ . ;)

As side note, to do so, we would need to make some kind of detection
where external include headers are.
1. using gcc to tell us where it does look (may be gcc specific)
2. using ffmpeg-config like system (won't work with older versions)
3. trying to guess all locations, including the strange one (e.g. mingw).


Any other comments before i commit?