[MPlayer-dev-eng] Re: [PATCH] 0/5 VT switching in fbdev

[Alban Bedel]

On Wed, 19 Apr 2006 23:42:58 -0400
Rich Felker <dalias at aerifal.cx> wrote:

> > 2/5 Make cmap a file-scope static variable
> > 3/5 Make vm a file-scope static variable
> 
> Static/global vars are unwanted cruft from a long time ago. New stuff
> should be moved to a private context for the vo instance.

Althought i would generaly fully agree with that, one have to note that
the current vo API have no provision for it :( Their is nowhere to store
priv data and even if there was, it would still be useless unless we
changed most callback to also take that context as parameter.

I would support such a move if it was also an occasion to cleanup the cruft
and sanitize the API a bit. We could get rid of the useless draw_frame in
favor of draw_image only. We could have a few standard fields in the vo struct
to store current res, colorspace, fullscreen state, etc. A lot could be done
to improve that aging API.

However for the time beeing i wouldn't see those lack in the vo API as
preventing the submitted patchs from going into cvs.

	Albeu