[MPlayer-dev-eng] [PATCH] disable filters that depend on dsputil.h

[Diego Biurrun]

On Wed, Apr 19, 2006 at 03:22:28PM +0300, Ivan Kalvachev wrote:
> 2006/4/17, Nico Sabbi <nicola_sabbi at fastwebnet.it>:
> > Nico Sabbi wrote:
> >
> > > Diego Biurrun wrote:
> > >
> > >> On Mon, Mar 20, 2006 at 01:35:38PM +0100, Diego Biurrun wrote:
> > >>
> > >>> On Thu, Mar 16, 2006 at 11:06:35PM +0100, Nico Sabbi wrote:
> > >>>
> > >>>> as for Ivan's request on IIRC I committed only configure,
> > >>>> libmpcodecs/Makefile and libmpcodecs/vf.c,
> > >>>> because the filter files can be modified in a different way.
> > >>>
> > >>> And how?  IMO this is just code obfuscation.  If it cannot and does not
> > >>> work with shared lavc, the code should not imply it does.
> > >>
> > >> Nico?
> > >
> > > sorry for the delay, I missed your previous mail.
> > >
> > > Ivan's intention (IIRC) was to change the #include directive so as
> > > if users use external libavcodec and copy dsputil.h in a global
> > > include directive those filters can be still used
> >
> > After Diego's request on irc I committed the changes to the filter
> > files, too.
> 
> Never do that again.
> 
> I did flame diego on irc. Do you really want to flame you too?
> 
> Always put warning and arguments on the mailling list. Diego is not
> project leader, nor some kind of dictator to overthrow other
> developers decisions.

Nor are you if I may remind you.

You have things backwards.  It's not Nico and I that have to justify our
actions, it's you.

Shared lavc support was implemented by myself and Nico.  While doing this
Nico put some #ifdef lines in lavc-dependent filters.  Michael spoke up
against (mis)using nonpublic header files, so the support for shared
lavc was removed from these filters again.

If you want to keep some leftover #ifdef lines in a filter, come up with
a good reason to keep them and a working implementation *first*.  #ifdef
is to be avoided, especially if it just obfuscates the code without
working.

Diego