[MPlayer-dev-eng] [PATCH] option to skip slow -identify output

[Oded Shimon]

On Tue, Apr 18, 2006 at 08:15:19PM -0400, kiriuja wrote:
> When -identify is used on a DVD, mp_describe_titleset is called for each
> VTS, which takes a lot of time if there are many of them.
> 
> So the attached patch skips that call along with DVDDiscID unless
> -identify is given twice.
> 
> Someone please check and apply.
> 
> --
> kiriuja

> Index: cfg-mplayer.h
> ===================================================================
> RCS file: /cvsroot/mplayer/main/cfg-mplayer.h,v
> retrieving revision 1.262
> diff -u -p -r1.262 cfg-mplayer.h
> --- cfg-mplayer.h	18 Apr 2006 11:06:35 -0000	1.262
> +++ cfg-mplayer.h	18 Apr 2006 17:41:48 -0000
> @@ -383,7 +383,7 @@ m_option_t mplayer_opts[]={
>  #undef MAIN_CONF
>          
>  	{"list-properties", &list_properties, CONF_TYPE_FLAG, CONF_GLOBAL, 0, 1, NULL},
> -	{"identify", &identify, CONF_TYPE_FLAG, CONF_GLOBAL, 0, 1, NULL},
> +	{"identify", cfg_inc_identify, CONF_TYPE_FUNC, CONF_GLOBAL, 0, 0, NULL},

The "CONF_TYPE_FUNC" are a horrible hack, and don't work well. I accept it 
only for -v as it is expected behavior. please find a better solution for 
this (another option, -videntify ?).
Also, is there any reason identify is CONF_GLOBAL?

- ods15