[MPlayer-dev-eng] [PATCH] switch audio delay keys

[Diego Biurrun]

On Sat, Apr 15, 2006 at 08:37:54PM +0300, Ivan Kalvachev wrote:
> 2006/4/15, Diego Biurrun <diego at biurrun.de>:
> >
> > Anyway, let's define what is needed here:
> >
> > - a certain behavior of the relationship of audio and video during
> >   playback, something that should be consistent with the word delay
> > - a certain behavior of the command line option
> > - a certain behavior of what is shown on the OSD
> > - a certain behavior of the keys controlling audio_delay
> >
> > First of all this needs to be consistent.  By consistent I mean that
> >
> > - positive values on the command line should correspond to positive
> >   values on the OSD
> > - the + and - keys should behave as expected with regard to the numbers,
> >   i.e. + should make the number increase, - should make it decrease
> >
> > This we have achieved right now.
> >
> > Then we have to decide what direction delay should be interpreted and
> > adjust the code to match that definition.  Right now positive values
> > mean that audio comes before video.
> 
> After some reasoning on IRC, I'm going to pass the modification.
> I still don't like changing behaviour I am already used to... Only
> because of wording issue.

Just redefine the keys via input.conf ..

Anyway, this is a conflict between the behavior of the command line and
the OSD and the intuitiveness of the keyboard controls that cannot be
resolved without breaking some backwards compatibility.

I agree that the current situation is not yet perfect.  We need to make
some code changes to fully fix the issue.

Diego