[MPlayer-dev-eng] Re: [PATCH] Automatic monitor aspect for X11

[Reimar Döffinger]

Hi,
On Sat, Apr 15, 2006 at 09:39:12AM +0200, Alban Bedel wrote:
> Well it's directly related to another var defined there (monitor_aspect)
> so that doesn't sound so weird to me. To be honest spreading related
> stuff all over the place is not really what i would call a good thing.

Well, we agree here. It's just my opinion that putting the variable
declaration in aspect.c and the code in x11_common.c was more "spreading
related stuff".
I did not find the other patch that was mentioned, so if that one is
really better I'm wasting my time in writing this, but my suggestion
would be to add something like a
"set physical monitor size" function to aspect.c (where this use_...
variable would be used) and only call that function in x11_common.c.

Greetings,
Reimar Döffinger