[MPlayer-dev-eng] [PATCH] Faad update, try2

[Diego Biurrun]

On Wed, Apr 12, 2006 at 01:20:46AM +0200, Roberto Togni wrote:
> 
> Works with all my samples.
> Works with sky.fm streams.
> Should work with fixed point (please test), but afaik not all features
> are supported in fixed-point mode (same as current faad in MPlayer cvs)
> 
> Some fixes are coded by exg.
> 
> Please test.

Bandit.mp4 still crashes in fixed mode, but this also happens with the
current version.  Other than that it works fine for me.

I made some benchmarks on my PowerBook (1500MHz G4, Debian unstable)
with samples available from

http://www.mplayerhq.hu/MPlayer/samples/A-codecs/AAC/

ct_faac.mp4 and  ct_nero-heaac.mp4 are audio-only files, for them I used
the command

mplayer -benchmark -ao pcm:file=/dev/null:fast:nowaveheader

For zx.eva.renewal.01.divx511.mkv I used

mplayer -vc null -vo null -benchmark -ao pcm:file=/dev/null:fast:nowaveheader

I took the best of 5 runs.  For float mode I took 20 runs after getting
wildly varying results on the zx.eva.renewal.01.divx511.mkv sample.  The
new version seems to be slightly faster even though I don't trust the
numbers too much.

Roberto, maybe double-check with some benchmarks on x86 and finally
commit this, we have been waiting for an updated FAAD version for ages.

Diego


results:

updated:

ct_faac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.250s Sys:   0.018s =    0.268s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 93.2138% Sys:  6.7862% = 100.0000%

ct_nero-heaac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.673s Sys:   0.022s =    0.695s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 96.7739% Sys:  3.2261% = 100.0000%

zx.eva.renewal.01.divx511.mkv:
BENCHMARKs: VC:   0.001s VO:   0.000s A:  12.294s Sys:   0.643s =   12.938s
BENCHMARK%: VC:  0.0109% VO:  0.0000% A: 95.0206% Sys:  4.9685% = 100.0000%


current:

ct_faac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.251s Sys:   0.018s =    0.270s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 93.1475% Sys:  6.8525% = 100.0000%

ct_nero-heaac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.674s Sys:   0.023s =    0.696s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 96.7650% Sys:  3.2350% = 100.0000%

zx.eva.renewal.01.divx511.mkv:
BENCHMARKs: VC:   0.001s VO:   0.000s A:  12.345s Sys:   0.650s =   12.997s
BENCHMARK%: VC:  0.0110% VO:  0.0000% A: 94.9867% Sys:  5.0023% = 100.0000%


updated fixed mode:

ct_faac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.507s Sys:   0.018s =    0.526s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 96.4970% Sys:  3.5030% = 100.0000%

ct_nero-heaac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.275s Sys:   0.010s =    0.284s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 96.5975% Sys:  3.4025% = 100.0000%

zx.eva.renewal.01.divx511.mkv:
BENCHMARKs: VC:   0.001s VO:   0.000s A:   4.998s Sys:   0.516s =    5.514s
BENCHMARK%: VC:  0.0197% VO:  0.0000% A: 90.6310% Sys:  9.3492% = 100.0000%


current fixed mode:

ct_faac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.519s Sys:   0.018s =    0.537s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 96.5864% Sys:  3.4136% = 100.0000%

ct_nero-heaac.mp4:
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.279s Sys:   0.009s =    0.288s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 96.7366% Sys:  3.2634% = 100.0000%

zx.eva.renewal.01.divx511.mkv:
BENCHMARKs: VC:   0.001s VO:   0.000s A:   5.074s Sys:   0.514s =    5.590s
BENCHMARK%: VC:  0.0208% VO:  0.0000% A: 90.7789% Sys:  9.2003% = 100.0000%