[MPlayer-dev-eng] Re: [PATCH] monitorpixelaspect option to supplement monitoraspect

[Alban Bedel]

On Fri, 14 Apr 2006 15:44:41 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hi,
> On Fri, Apr 14, 2006 at 03:29:16PM +0200, Alban Bedel wrote:
> > On Fri, 14 Apr 2006 14:40:15 +0200
> > Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > > +A value of 0 disables, for most monitors and (almost?) all LCD,
> > >  1 is a good value.
> > 
> > A bit of nitpicking :) Pixels can have any aspect ratio, so their is no
> > "good" value, it's either right or wrong. Perhaps something along the
> 
> Well, e.g. "good" in the sense of "looks good". The correct value is not
> necessarily the desired one *g*

Ahh, lusers :)

> > lines of: "A value of 0 disables, 1 set square pixels." would be better.
> 
> I changed it locally to:
> "A value of 0 disables, a value of 1 means square pixels
> (correct for (almost?) all LCDs)."
> 
> Does that sound better (I expect the documentation guys to do a bit of
> polishing afterwards anyway *g*)?

That sound better to me, but yeah the doc ppl are probably gonne change
it anyways :)

	Albeu