[MPlayer-dev-eng] [PATCH] Use XScreenSaverSuspend if supported

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Apr 12 13:09:59 CEST 2006


Hi,
>  
> -    int interval, prefer_blank, allow_exp;
> +    int interval, prefer_blank, allow_exp, nothing;
> +
> +#ifdef HAVE_XSCREENSAVER_SUSPEND
> +    if (have_xscreensaver_suspend)
> +    {
> +        XScreenSaverSuspend(mDisplay, True);
> +        return;
> +    }
> +#endif
>  
>  #ifdef HAVE_XDPMS
> -    int nothing;
>  
>      if (DPMSQueryExtension(mDisplay, &nothing, &nothing))
>      {

Since moving "nothing" up may cause a "unused variable" warning, just
creating a new block inside the "HAVE_XDPMS" part may be preferable.
And are you sure that the DPMS stuff will be handled by
XScreenSaverSuspend as well? I couldn't find any documentation for it
:-(
If you're not sure I'd suggest putting the XScreenSaverSuspend stuff
just below the DPMS stuff.

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list