[MPlayer-dev-eng] Re: [PATCH] GUI: fix audio/video id in gtk/menu.c

[Nico Sabbi]

Stanislav Maslovski wrote:
> On Tue, Apr 11, 2006 at 11:13:34AM +0200, Guillaume Poirier wrote:
>   
>> Hi,
>>
>> Stanislav Maslovski wrote:
>>     
>>> On Tue, Apr 11, 2006 at 12:36:54PM +0400, Stanislav Maslovski wrote:
>>>       
>>>> When playing an ogg file in gmplayer I noticed that changing audio streams
>>>>         
>>> >from the menu was buggy. An investigation showed that in gtk/menu.c the
>>>       
>>>> audio and video streams' IDs were assumed to be equal to the indexes of
>>>> the corresponding demuxer->a_streams[i] and demuxer->v_streams[i] members.
>>>> However, from reading demux_ogg.c and demux_mkv.c codes I see that those
>>>> IDs are simply continuously counted from 0. Please, correct me if I am wrong
>>>> or if there are other cases I have not noticed.
>>>>         
>>> I mean the IDs that are used in -aid, for example.
>>>       
>> Isn't precisely -aid a counter example? On DVDs, "aid" starts at 128,
>> and on some dvb streams I've had on hand, it started at 130...
>>     
>
> Well, as i said i have checked only mkv and ogg demuxers ;) So, there is no
> standard for -aids and similar in mplayer?
>
> The GUI code treats DVD case in a different manner: the part of the code the
> patch affects is simply skipped for a DVD (see line 23710 of gtk/menu.c).
>
> Where a dvb stream gets demuxed? I can add a special case for it.
>   

demux_ts.c. No special cases, please: they are evil

 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Vuoi una ricetta molto interessante per i tuoi risparmi?
* Ti serve Conto Arancio!
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=5041&d=11-4