[MPlayer-dev-eng] Re: [PATCH] GUI: fix audio/video id in gtk/menu.c

[Guillaume Poirier]

Hi,

Stanislav Maslovski wrote:
> On Tue, Apr 11, 2006 at 12:36:54PM +0400, Stanislav Maslovski wrote:

>>When playing an ogg file in gmplayer I noticed that changing audio streams
>>from the menu was buggy. An investigation showed that in gtk/menu.c the
>>audio and video streams' IDs were assumed to be equal to the indexes of
>>the corresponding demuxer->a_streams[i] and demuxer->v_streams[i] members.
>>However, from reading demux_ogg.c and demux_mkv.c codes I see that those
>>IDs are simply continuously counted from 0. Please, correct me if I am wrong
>>or if there are other cases I have not noticed.
> 
> 
> I mean the IDs that are used in -aid, for example.

Isn't precisely -aid a counter example? On DVDs, "aid" starts at 128,
and on some dvb streams I've had on hand, it started at 130...

So your assumption doesn't seem to be correct. Do you have a way to test
you patch with a DVD?

Guillaume