[MPlayer-dev-eng] [PATCH] Use XScreenSaverSuspend if supported

[Reimar Döffinger]

Hi,
On Mon, Apr 10, 2006 at 08:49:16PM +0300, Ismail Donmez wrote:
>  void saver_on(Display * mDisplay)
>  {
> +#ifdef HAVE_XSCREENSAVER_SUSPEND
> +    XScreenSaverSuspend(mDisplay, False);
> +    return;
> +#endif
>  
>  #ifdef HAVE_XDPMS
>      int nothing;

Unless there are cases where XScreenSaverSuspend might not work and you
check for this, IMHO you should put the rest of the code under #else.
No point in compiling code that can never be executed...

> @@ -1684,6 +1692,11 @@
>  
>      int interval, prefer_blank, allow_exp;
>  
> +#ifdef HAVE_XSCREENSAVER_SUSPEND
> +    XScreenSaverSuspend(mDisplay, True);
> +    return;
> +#endif
> +
>  #ifdef HAVE_XDPMS
>      int nothing;

esp. since in this case it would probably break compilation with gcc
2.95 (declaration "int nothing;" after code).

Greetings,
Reimar Döffinger