[MPlayer-dev-eng] [PATCH] GUI: segfault in sb.c; window size & localization in eq.c;

[Guillaume POIRIER]

Hi,

On 4/9/06, Stanislav Maslovski <stanislav.maslovski at gmail.com> wrote:
> On Sun, Apr 09, 2006 at 03:16:42PM +0200, Guillaume POIRIER wrote:
> > Hi,
> >
> > On 4/6/06, Stanislav Maslovski <stanislav.maslovski at gmail.com> wrote:
> > > Hello,
> > >
> > > The attached patch fixes the following issues in MPlayer's GTK+ GUI:
> > >
> > >  * segfault in the skin browser when sbSelectedSkin gets dereferenced
> > >    before setting, when no skin is selected in the skin list upon opening
> > >    the browser, and "Cancel" or "OK" buttons get clicked. Noticed when
> > >    runnig freshly compiled gmplayer on a system where the skins were
> > >    still under the old location.
> > >
> > >  * vertical size of "Configure Equalizer" window was not enough to hold all
> > >    comboboxes.
> > >
> > >  * the title of this window was not localized => added new en and ru strings.
> >
> > I'm gonna apply this patch in a minute. Nobody maintains currently gui
> > code anyway, and the code seems reasonable.
>
> Thanks!

No problem. If you have some unapplied patches about the GUI, please
send a reminder to them so I can apply them. As I said, nobody
maintains the GUI, so if you want to take care of it, you're more than
welcome to come aboard!

Guillaume
--
I am disillusioned enough to know that no man's opinion on any subject
is worth a damn unless backed up with enough genuine information to
make him really know what he's talking about.

-- H. P. Lovecraft (about the flamewars on FFmpeg and MPlayer-dev mailing lists)
http://www.brainyquote.com/quotes/quotes/h/hplovecr278144.html