[MPlayer-dev-eng] Re: [PATCH] New mode for 'tinterlace' filter

[Walter Belhaven]

Ivan Kalvachev writes:
> 2006/4/2, Walter Belhaven :
> >
> > Here's a patch to libmpcodecs/vf_tinterlace.c which adds a new
> > mode (-vf tinterlace=4).
> 
> Committed.

Thanks, but I was hoping to get some feedback/advice on the question I
posed in my original E-mail and within the comments of the code. 
Namely, how should I set dmpi->fields of the image returned by
vf_get_image() -- should I set MP_IMGFIELD_INTERLACED? -- how about
MP_IMGFIELD_TOP_FIRST? etc.

[NOTE: I should have placed those comment/lines inside the "if", right
after dmpi=vf_get_image(...), not outside the "if".  Uncommenting them
where they are right now will causes a dereference-of-null segfault.]

> Next time add to the patch and entry for the man page (i wrote one, i
> hope you like it. if not, send patch ;)

Can you point me to where I would find such a thing?  Yours is fine,
but I think the original documentation of tinterlace=0 is broken -- it
should say double-height, and I'm not sure it's correct regarding field
order.

> About my_memcpy_pic(), i'm gonna make few benchmarks first and then
> decide what to do.

Sounds reasonable.  Thanks for your help on this.

WB




__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com