[MPlayer-dev-eng] [PATCH] Remove bogus Vorbis pts values from Matroska demuxer

Rich Felker dalias at aerifal.cx
Fri Apr 7 21:09:01 CEST 2006


On Fri, Apr 07, 2006 at 01:36:57PM +0300, Uoti Urpala wrote:
> The Matroska demuxer currently gives the same pts value for each laced
> Vorbis packet. These bogus pts values make av sync unstable. The
> attached patch removes pts values from packets other than the first
> laced packet when the track has no default packet duration (there is no
> way to give them correct timestamps other than decoding the packets and
> calculating the length of the resulting audio).
> 
> Are there any cases where default_duration would be 0 and giving all the
> packets the same pts value would be the right thing to do? If there are
> then this fix could be changed to affect Vorbis streams only.

No, it's never correct for two packets to have same pts.

Rich




More information about the MPlayer-dev-eng mailing list