[MPlayer-dev-eng] [PATCH] switch audio delay keys

[The Wanderer]

Ivan Kalvachev wrote:

> 2006/4/6, Rich Felker <dalias at aerifal.cx>:
> 
>> On Thu, Apr 06, 2006 at 10:50:20AM +0300, Ivan Kalvachev wrote:
>> 
>>> I think that now i get what is the problem.
>>> 
>>> The word "delay".
>> 
>> It depends on your interpretation. Is the -delay T option a command
>> to delay the audio by T seconds (IMO the natural interpretation and
>> the one with respect to which the current behavior is incorrect),
>> or a statement that the file's audio is delayed by T seconds and
>> needs to be corrected (unusual interpretation but matches
>> behavior)?
> 
> Anyway... the problem is in documentation wording and must be fixed
> there. MPlayer behaves consistently. E.g. when changing dalay the osd
> displays "A-V delay:+0.100" perfectly obvious and correct.

Except that it displays the "plus" when the user just hit "minus". This
is either not consistent or, at the very least, not intuitive.

(I'd be inclined to say the latter, given that passing a
positively-signed argument to the "-delay" option gives the initial
value for that number a positive sign.)

> Documentation must be changed to respect what mplayer does, not the
> opposite.

This is inappropriate if what MPlayer does is incorrect. That has not
been disproven in this instance.

> You can consider this patch rejected.

Not as far as I'm concerned. I'm not going to apply it on my own
recognizance, but I do not consider your authority to be sufficient to
reject it, especially since I don't think I've heard anyone else support
your reasoning and do not myself find it remotely persuasive; in fact,
I'm not sure that your argument consists of anything more than an
assertion of the premise that "the current behaviour does not need to be
changed", which is also your conclusion - it's a perfectly reasonable
thing to argue for, but I don't remember (having just checked over your
mails in this thread so far) having seen you present anything I can
immediately identify as being an argument.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.