[MPlayer-dev-eng] [PATCH] verbosity reduction

[The Wanderer]

Reimar Döffinger wrote:

> Hi, On Wed, Sep 28, 2005 at 11:06:18AM -0400, The Wanderer wrote:
> 
>> Why would that be prohibitively complex? On the surface it seems
>> fairly simple; create a "verbosity" variable for each such
>> category, set it to be initially equal to MSGL_STATUS (which is the
>> default verbosity), sum it with the value passed for that category
>> on the command line, and then
> 
> Good idea so far...
> 
>> change every mp_msg call to be of the form "mp_msg(MSGT_FOO,
>> MSGL_FOO + verbosity, ...) (where "verbosity" is the appropriate
>> variable for the
> 
> Now it is getting stupid. Why should the caller decide on verbosity?
> The mp_msg function can do this, after all there is the MSGT_* for
> some reason... Changing all mp_msg calls is not acceptable anyway
> IMO.

Because I couldn't think of any other good way to "know" what context
the call was being made from, i.e. which part of MPlayer we were talking
about. I was very tired at the time; as you note, obviously MSGT can be
used for that purpose.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.