[MPlayer-dev-eng] [PATCH] panscanrange option

[The Wanderer]

Reimar Döffinger wrote:

> Hi,
> attached patch adds a panscanrange option, effecting how panscan
> works.
> Using negative values e.g. allows doing panscan without cropping the
> borders first. See man page part for details.
> I intend to apply tomorrow if nobody has suggestions/objections.

Commenting where I can (that being, of course, just the docs part):

>  .TP
> +.B \-panscanrange <-19.0\-99.0> (experimental)
> +Change the range of the pan-and-scan functionality.
> +Positive values means you can zoom up to this many time the factor needed
> +to remove the borders.

This sentence a) is ungrammatical (at bare minimum, it needs "times"
instead of "times" and either "mean" instead of "means" or "A positive
value" instead of "Positive values"), and b) is not necessarily clear.
Does it in fact mean "there is a factor which is necessary to remove the
borders, and this specifies the multiple of that factor to which it is
possible to zoom"? If not, then I don't know what is actually meant. (If
*so*, then I don't know where the factor in question is supposed to come
from - perhaps from the -panscan option? If so, what happens if
-panscanrange is specified but -panscan is not? A (very) quock glance at
the code part of the patch seems to indicate "nothing", but I don't
necessarily trust myself to be able to tell - even though that part of
the code seems comparatively simple.)

> +Negative numbers mean you can zoom in up to a factor of -panscanrange+1.
> +E.g. \-panscanrange -3 allows a zoom factor of up to 4.

Here, you say "zoom in", whereas above you say just "zoom", This should
be made consistent.

Do I understand correctly that negative values are just a different way
of specifying some of the positive values - i.e., the results of
'-panscanrange -3' would be identical to the results of '-panscanrange
4'? If not, then I don't understand what is being said here.

> +This feature is experimental, only report bugs when using -vo gl.

I'd prefer

==
This feature is experimental. Do not report bugs unless you are using 
-vo gl.
==

or similar

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.