[MPlayer-dev-eng] [PATCH] XviD and -passlogfile

[Ivo]

On Sunday 25 September 2005 22:14, Alexander Strasser wrote:
> Hi,
>
> Ivo wrote:
> > On Sunday 25 September 2005 21:41, Olivier Rolland wrote:
> > > Here is a very simple patch to make xvid encoding use the filename
> > > from -passlogfile to store and retreive pass information.
> >
> > This should be made into an xvidencopts suboption IMO.
>
>   Why? It is a general setting for more pass encodings so it
> does make no sense to duplicate it in every encoders subopts
> that might have use for it.

It's just one line per encoder, so I don't think that really counts as code 
duplication. IMO it's cleaner to have a passlogfile= (or something similar) 
suboption and no global variables to pass a parameter to an encoder.
But I agree that it won't make much sense to do it only for XviD and leave 
the -passlogfile command line option intact for all other encoders.

--Ivo