[MPlayer-dev-eng] [PATCH] XviD and -passlogfile

Ivo ivop at euronet.nl
Sun Sep 25 23:13:51 CEST 2005


On Sunday 25 September 2005 22:07, Guillaume POIRIER wrote:
> Hi,
>
> On 9/25/05, Ivo <ivop at euronet.nl> wrote:
> > On Sunday 25 September 2005 21:41, Olivier Rolland wrote:
> > > Hey,
> > >
> > > Here is a very simple patch to make xvid encoding use the filename
> > > from -passlogfile to store and retreive pass information.
> >
> > This should be made into an xvidencopts suboption IMO.
>
> No, not at all! lavc honnors this switch! XviD should just do the
> same, doesn't it?

Yes, but IMHO both should use a suboption. It will eliminate a global 
command line option, which is a good thing imo, and also removes the need 
for (more) global variables that polute the namespace.

--Ivo




More information about the MPlayer-dev-eng mailing list