[MPlayer-dev-eng] [PATCH] Make frameno.avi optional

[Dominik 'Rathann' Mierzejewski]

On Monday, 19 September 2005 at 15:50, Rich Felker wrote:
> On Mon, Sep 19, 2005 at 03:31:50PM +0200, Ivo wrote:
> > On Monday 19 September 2005 13:22, Oded Shimon wrote:
> > > I'd like to atleast make this very obsolete feature optional (I'm in
> > > favor of ripping it out of MEncoder altogether, MEncoder's source is
> > > hackish enough as it is...).
> > > With this patch, you have -frameno-file where you can now actually
> > > specify the frameno filename, and also MEncoder doesn't show the very
> > > annoying and very stupid 'file not found frameno.avi' at startup.
> > > I'm not sure if to document this option at all, as it'll encourage people
> > > to actually use it.
> > >
> > > Thoughts? I'll commit soon if no-one objects, and that's a threat. (It
> > > breaks any scripts which assumed MEncoder automatically uses frameno.avi)
> > 
> > Why not just change the mp_msg call to MSGL_V and leave the rest as it is? I 
> > see no reason to change the behaviour of obsolete functionality.
> 
> Not possible. The message is important if you're trying to open a REAL
> file, and it's not generated by mencoder.c but by the stream layer
> when trying to load the file. I looked into this problem once before,
> and Oded's patch is the only correct (non-hack) fix.
> 
> Also I'll be GLAD to break existing functionality and require users
> still using frameno.avi to modify their configs. frameno.avi is VERY
> broken, deprecated, and should eventually be removed.

It's great for quickly extracting VOBsubs, though.

mencoder -ovc frameno -oac copy -o /dev/null -vobsubout name dvd://
is faster than with -ovc copy.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"