[MPlayer-dev-eng] [PATCH] verbosity reduction
Diego Biurrun
diego at biurrun.de
Mon Sep 19 10:05:53 CEST 2005
On Mon, Sep 19, 2005 at 09:13:24AM +0300, Oded Shimon wrote:
> On Sun, Sep 18, 2005 at 09:22:30PM +0200, Diego Biurrun wrote:
> > Here is another in my seemingly endless series of small patches that
> > reduce overall verbosity bit by bit.
> >
> > Comment or see this applied in a few days ;)
>
> Sorry, I object :/
> Some of these messages are important to track down troubles instantly,
Nonsense, there is no need for MPlayer to tell you that your CPU
supports AltiVec instructions to track down a problem.
> digging through -v is very hard if you just want to check a simple problem.
That's because verbose mode is also much too verbose and prints out a
lot of information that is only good for hardcore debugging purposes.
> Also, your patch is broken - the CPU messages appear before the command
> line parser, try it, with your patch, even with -v, i won't see the cpu
> info.
I know. Read through the rest of cpudetect.c, there are a lot of
verbose level messages already. If you wish to fix this, make MPlayer
parse the command line first.
> MPlayer's verbosity is a feature, not a bug... If it bothers you, use
> -really-quiet :)
Verbosity is never a feature and we are even getting complaints about
MPlayer's excessive verbosity. Go read about the rule of silence in The
Art of Unix Programming:
http://www.catb.org/~esr/writings/taoup/html/ch01s06.html#id2878450
> (A certain verbosity i would like to remove is the very annoying output
> from mencoder:
> File not found: 'frameno.avi'
> Failed to open frameno.avi
> It's the worst output ever, it almost encourages using frameno..)
Yes, go ahead, remove it.
Diego
More information about the MPlayer-dev-eng
mailing list