[MPlayer-dev-eng] [PATCH] VFCTRL_PAUSE_UPDATE

[Reimar Döffinger]

Hi,
On Thu, Sep 15, 2005 at 02:30:06PM -0400, Jason Tackaberry wrote:
> On Thu, 2005-09-15 at 18:56 +0200, Reimar Döffinger wrote:
> > Actually I'd like to suggest the attached patch instead.
> [...]
> > +static int periodic_update(vf_instance_t *vf, vo_functions_t *vo,
> > +                           float time_avail) {
> > +  int res;
> > +  if (!vf) return 0;
> > +  if (time_avail < 0.01) return 1; 
> 
> Actually this last line is a bit arbitrary.  In fact, 1000 microseconds
> is a lot of time depending on what needs to be done.  And what needs to
> be done will depend on the filter.  Why not remove that constraint and
> let the filter decide if it should update or not?  Since the filter is
> given time_avail and it knows what it needs to do, it will be able to
> make a more intelligent choice.

Actually the idea was that if time_avail < 0.01 the next update will
happen in around 10 milliseconds anyway.
But actually I created a seperate function on purpose, so this value
will be in one place and easy to change.

Greetings,
Reimar Döffinger