[MPlayer-dev-eng] [PATCH] VFCTRL_PAUSE_UPDATE

[Rich Felker]

On Thu, Sep 15, 2005 at 01:49:35PM -0400, Jason Tackaberry wrote:
> Hi Reimar,
> 
> On Thu, 2005-09-15 at 18:56 +0200, Reimar Döffinger wrote:
> > Actually I'd like to suggest the attached patch instead. I didn't test
> > it though and vf_overlay must be changed a bit to work with it, but
> 
> I updated vf_overlay to work with your changes and everything seems
> good.  Your approach is much better, because it moves flip_page() out of
> the filter and into mplayer.c, which is where it ought to be, otherwise
> with more than one filter handling the VFCTRL you'd see a flicker as
> each filter flipped the page.
> 
> There is a problem with double buffering, though.  If you flip_page()
> while mplayer is in the sleep code and double buffering is used, there
> will be a most unpleasant flicker.  I don't know enough about mplayer's
> architecture to see how to fix this bug.

This means that the filter did not submit a new picture to the vo, and
therefore flipping should not be taking place.

Rich