[MPlayer-dev-eng] Re: [PATCH] Auto load vobsub from ~/.mplayer/sub and oss mixer settings "per instance"

[Alban Bedel]

On Thu, 15 Sep 2005 18:48:16 +0200

> Hi,
> On Thu, Sep 15, 2005 at 06:23:35PM +0200, Alban Bedel wrote:
> > > Nice, but IMHO the whole mixer_channel thing including the global
> > > option should be removed.
> > 
> > I'm not sure what you mean exactly. Ignore the -mixer-channel option ?
> > That doesn't sound like a good idea to me.
> 
> No, remove it. It is ao-specific, so it should be a suboption.

Ok, i see what you mean. Then let's do it cleanly: switch all ao
usig mixer_device to suboption and turn the global option in a print
to warn the users. And mixer_device could get the same fate.

> > > Also I think the suboption parser
> > > should be used (see subopt-helper.h and e.g. vo_gl.c, preinit function
> > > on how to use it).
> > 
> > Imho it's not worth it considering that all options are strings and
> > it would break compatibility afaik.
> 
> Well, your version implements yet another parser. A simple one though,
> which means that if ever somebody wants to add more options has a hard
> time and will have to break compatibility anyway.
> At least that is my opinion on this. Also using the subopt-helper you
> can also benefit from escaping (ok, it's not really good yet) because in
> theory specifying a device name containing a ':' isn't possible anymore
> afer your patch ;-)

Ok, a more important "plus" point imho is the improved consistancy
betwen the various drivers. Or at least it get closer to having something
consistant :)

	Albeu