[MPlayer-dev-eng] [PATCH] big vf_osd update

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Sep 15 17:31:47 CEST 2005


Hi,
On Thu, Sep 15, 2005 at 10:58:56AM -0400, Jason Tackaberry wrote:
> On Thu, 2005-09-15 at 15:39 +0200, Diego Biurrun wrote:
> > These look like things that you might wish to submit as separate patches.
> > It would make reviewing them easier and speed up the integration of
> > vf_overlay.
> 
> I've made a diff of diffs and grouped most of the changes into separate
> files.  This diff compares the two patches before the rename from vf_osd
> to vf_overlay, otherwise the SNR would have been pretty low and would
> have made reviewing difficult.

I don't know what Diego exactly wanted... I for me have to say thank
you for your effort, but those patches aren't worth anything to me since
I hadn't finished reviewing the other part.
Though there is one thing I'd like to ask: The pause update VFCTRL I
think can be applied seperately, maybe you can cut that out so it can be
reviewed seperately.
The reason for this is that
1) I think this is the only part that can break something existing
2) Is really small and thus more probable to be reviewed.

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list