[MPlayer-dev-eng] [PATCH] XviD profile support

Diego Biurrun diego at biurrun.de
Wed Sep 14 00:56:46 CEST 2005


On Tue, Sep 13, 2005 at 01:38:26PM +0100, Robert Swain wrote:
> On 9/13/05, Diego Biurrun <diego at biurrun.de> wrote:
> > I cannot comment on the code part of the patch, but I see that you
> > exceed 80 characters on many lines, please try to avoid this.
> 
> I have found a "long line" marker feature of my text editor. I see
> there are indeed lots of lines which extend beyond 80 characters. Out
> of interest, where does this limit come from? Low resolution terminal
> editors or something else?

Yes, ideally code should be easily readable in a console editor or pager
since this is the work environment for many people.  Diffs are also
often read on the console and the default console width is 80
characters.  I believe it also helps overall readability.  When
typesetting text you aim to keep the line length in a good relation to
font size.  That way the information is easier to grasp for the brain.

Diego




More information about the MPlayer-dev-eng mailing list