[MPlayer-dev-eng] [PATCH] XviD profile support

[Robert Swain]

Hello,

On 9/13/05, Diego Biurrun <diego at biurrun.de> wrote:
> On Mon, Sep 12, 2005 at 02:54:32AM +0100, Robert Swain wrote:
> > On 9/10/05, Guillaume POIRIER <poirierg at gmail.com> wrote:
> > > The comments you added should, I think, use doxygen-style I think
> > > there is a doc about this on DOCS/tech.
> >
> > After a short discussion, my feelings were - "I haven't seen anyone
> > else using doxygen comments, why should I?" If anyone has a good
> > explanation then I'm perfectly willing, I'm just unsure what should be
> > a doxygen comment and what should not.
> 
> Well, you have to start somewhere, getting all the code documented is a
> huge undertaking that will probably take years to complete, so we made a
> policy that forces new code to be properly documented.
> 
> Read DOCS/tech/code-documentation.txt for the gory details.

Indeed it would be a big task and I didn't realise this was an aim of
the project. It is certainly noted and I will do my best to use
doxygen comments appropriately in the future. Thank you.

On 9/13/05, Diego Biurrun <diego at biurrun.de> wrote:
> On Mon, Sep 12, 2005 at 11:50:01PM +0100, Robert Swain wrote:
> >
> > Please find revision 2 attached.
> >
> > --- DOCS/man/en/mplayer.1     11 Sep 2005 08:00:22 -0000      1.1094
> > +++ DOCS/man/en/mplayer.1     12 Sep 2005 21:04:07 -0000
> > @@ -7976,6 +7976,56 @@
> > +.B profile=<option>
> > +Restricts options and VBV (peak bitrate over a short period) according to the
> > +Simple, Advanced Simple and DivX profiles. The resulting videos should be
> > +playable on standalones adhering to these profile specifications.
> 
> Start new sentences on a new line in the man page.
> 
> > +.I NOTE:
> > +These profiles should be used in conjunction with an appropriate -ffourcc.
> 
> \-ffourcc
> 
> I cannot comment on the code part of the patch, but I see that you
> exceed 80 characters on many lines, please try to avoid this.

I have found a "long line" marker feature of my text editor. I see
there are indeed lots of lines which extend beyond 80 characters. Out
of interest, where does this limit come from? Low resolution terminal
editors or something else? There isn't much I can do with the
profiles[] array unless it is preferable that I remove the unused
information to condense it somewhat, but I will do my best with the
rest.

Thanks for your comments Diego.
Regards,
Robert Swain (superdump)