[MPlayer-dev-eng] [PATCH] yuv support for vo_gl

[Vladimir Mosgalin]

Hi Reimar D?ffinger!

 On 2005.09.12 at 17:25:33 +0200, Reimar D?ffinger wrote next:

> On Mon, Sep 12, 2005 at 01:45:32PM +0200, Reimar D?ffinger wrote:
> > On Sun, Sep 11, 2005 at 12:00:21AM +0400, Vladimir Mosgalin wrote:
> > > Colors in gl:yuv=2 are fixed now, however green border remains.
> > Could it be that this happens only whe the image gets scaled up? Or
> > always?
> > A few things you can try (should be independant):
> > 1) in vo_gl.c, replace all GL_LINEAR by GL_NEAREST
> > 2) in gl_common.c try replacing GL_CLAMP by GL_CLAMP_TO_EDGE or
> > GL_REPEAT.
> 
> Bah, I read the specs and it should be GL_CLAMP_TO_EDGE instead of
> GL_CLAMP!
> I've been searching for this bug for quite some time since it makes -vo
> gl2 look really bad when it uses multiple textures.
> That's what you get when you just copy the code from vo_gl2.c without
> checking the specs...

Well, what should I say? You're great, all visual problems have gone.
Haven't tried GL_NEAREST, the result would probably be to horrible to
watch anyway ;)


PS since you are already on a path of bug hunting and docs reading, what
would you say about yellow-blue effect in gl2 osd? It's present ever
since gl2 vo appeared.. or since osd support appeared in gl.

-- 

Vladimir