[MPlayer-dev-eng] [PATCH] vf_osd updates - fully baked?

[Michael Niedermayer]

Hi

On Mon, Sep 12, 2005 at 10:30:46AM +0200, Reimar D?ffinger wrote:
[...]
> > +#define FALSE 0
> > +#define TRUE !FALSE
> 
> I really _hate_ it when people use defines for things like that. Why
> isn't just using 0 and 1 good enough? I think at least every C programmer
> knows that 1 is true and 0 is false...

1


[...]
> 
> > +        "movl %4, %%eax\n\t"          // %eax = layer alpha
> > +        "cmpl $255, %%eax\n\t"        // don't apply layer alpha if it's 100% opaque
> "mov %4, %%"REG_a"\n\t"          // %eax = layer alpha
> "cmp $255, %%"REG_a"eax\n\t"        // don't apply layer alpha if it's 100% opaque
> 
> and include (I think) cpudetect.h. Otherwise it won't work on AMD64.

0
this is silly to begin with, it should be cmpl $255, %4 or so unless eax is
used somewhere else which if iam not blind it is not

[...]

-- 
Michael