[MPlayer-dev-eng] [PATCH] XviD profile support

[Guillaume POIRIER]

Hi,

On 9/10/05, Robert Swain <robert.swain at gmail.com> wrote:
> Hello all,
> 
> This patch adds Simple, Advanced Simple and DivX profile support.
> 
> Usage is:
> profile=<option>
> Restricts options and VBV according to the Simple, Advanced Simple and
> DivX profiles.

What does VBV mean? Maybe I know, but Joe-six-pack doesn't :-)

I think you should add smth like: "the resulting videos will have a
greater chance to be decoded correctly by standalone and third party
players."

Maybe a note about using that option along with "-fourcc" may be a good idea...

Other than that, the code seems quite right to me.
I wonder if the big structure: const profile_t profiles[] should go to
the .h file...

+	if ((profiles[proftonum(xvidenc_profile)].flags & PROFILE_MPEGQUANT) && 
+		(xvidenc_quant_method != NULL) && !strcasecmp(xvidenc_quant_method, "mpeg"))
+	{
+		frame->vol_flags |= XVID_VOL_MPEGQUANT;

if MPEG quant are not supported (on H.263) by DivX, maybe you should
add a comment about this here.

The comments you added should, I think, use doxygen-style I think
there is a doc about this on DOCS/tech.

Last but not least, add a patch to the AUTHORS file! ;-P

Guillaume
-- 
Reading doesn't hurt, really!
  -- Dominik 'Rathann' Mierzejewski